-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NTP search promo P3A question #14189
Conversation
4d87138
to
9c58091
Compare
@@ -83,6 +86,10 @@ void BraveNewTabPageHandler::InitForSearchPromotion() { | |||
base::Unretained(this))); | |||
template_url_service_observation_.Observe( | |||
TemplateURLServiceFactory::GetForProfile(profile_)); | |||
|
|||
brave_search_conversion::p3a::RecordPromoShown( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is called whenever NTP is created if promotion is enabled.
However, NTP will not show promotion when sponsored images are displayed.
When sponsored images are displayed, this should not be called.
I'll push another commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed 0e00a36
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ first commit :)
Kindly ping @iefremov :) |
Resolves brave/brave-browser#24065
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Regression testing of brave/brave-browser#23191 recommended.
--enable-features="BraveSearchNTP"
switch, with fresh profile.brave://local-state
, ensureBrave.Search.Promo.NewTabPage
does not exist.brave://settings/search
, change search engine to something other than Brave.brave://settings/search
(may be good to test both).