Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted hardcoded country list for search promo (uplift to 1.43.x) #14935

Merged
merged 1 commit into from
Sep 1, 2022
Merged

Deleted hardcoded country list for search promo (uplift to 1.43.x) #14935

merged 1 commit into from
Sep 1, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 31, 2022 •
edited by kjozwiak
Loading

Uplift of #14909
fix brave/brave-browser#25087

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 31, 2022 23:58
@brave-builds brave-builds self-assigned this Aug 31, 2022
@brave-builds brave-builds added this to the 1.43.x - Release milestone Aug 31, 2022
@simonhong simonhong self-assigned this Sep 1, 2022
kjozwiak
kjozwiak approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍 QA has verified the PR on Nightly as per brave/brave-browser#25087 (comment).

@kjozwiak kjozwiak merged commit 34bd1d4 into 1.43.x Sep 1, 2022
@kjozwiak kjozwiak deleted the pr14909_delete_search_promo_hardcoded_country_list_1.43.x branch September 1, 2022 03:35
@kjozwiak kjozwiak mentioned this pull request Sep 1, 2022
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @simonhong @brave-browser-releases