Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert portfolio page virtualized tokens list #15181

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

josheleonard
Copy link
Contributor

@josheleonard josheleonard commented Sep 22, 2022

Resolves brave/brave-browser#25565

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2022-09-22.at.12.23.03.PM.mov

@josheleonard josheleonard self-assigned this Sep 22, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 22, 2022
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@josheleonard josheleonard merged commit 046d154 into master Sep 23, 2022
@josheleonard josheleonard deleted the revert-fix-virtualize-token-lists branch September 23, 2022 13:43
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Sep 23, 2022
@Douglashdaniel
Copy link
Contributor

Looks like this is currently in 1.45.x beta #14817, should we uplift this revert?

@josheleonard
Copy link
Contributor Author

Uplift PR created: #15220

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.17 Chromium: 106.0.5249.65 (Official Build) nightly (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from PR
  • Verified the entire page is scrollable now and not just the token list
15181.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert Virtualized tokens list in portfolio page
4 participants