Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change debounce behavior to never debounce to same eTLD+1 #15392

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Oct 7, 2022

Resolves brave/brave-browser#25859

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave self-assigned this Oct 7, 2022
@pilgrim-brave pilgrim-brave requested a review from bridiver October 7, 2022 19:01
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_debounce_same_etldp1 branch from 1ef86a2 to 89cd92a Compare October 11, 2022 15:48
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_debounce_same_etldp1 branch from 89cd92a to b114489 Compare October 13, 2022 14:59
@pilgrim-brave pilgrim-brave enabled auto-merge (squash) October 13, 2022 17:26
@pilgrim-brave pilgrim-brave merged commit 8db01cb into master Oct 13, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_debounce_same_etldp1 branch October 13, 2022 18:37
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Same-site debouncing restriction should be based on eTLD+1
2 participants