Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): Edit Visible Assets Network Selector #15519

Merged
merged 1 commit into from
Oct 21, 2022
Merged

feat(wallet): Edit Visible Assets Network Selector #15519

merged 1 commit into from
Oct 21, 2022

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Oct 18, 2022 •
edited
Loading

Description

  • Adds the ability to filter the Edit Visible Assets by network
  • Introduces useTokenRegistry hook we can start to migrate to and eventually remove fullTokenList from redux.

Resolves brave/brave-browser#23675
Resolves brave/brave-browser#21770

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screen.Recording.2022-10-18.at.5.22.39.PM.mov

@Douglashdaniel Douglashdaniel self-assigned this Oct 18, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 18, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

onyb
onyb reviewed Oct 19, 2022
View reviewed changes
Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it useful to have an "All networks" option for Visible Assets modal? The default network in the dropdown should be the currently selected network.

@Douglashdaniel
Copy link
Contributor Author

Is it useful to have an "All networks" option for Visible Assets modal? The default network in the dropdown should be the currently selected network.

@onyb This was discussed/decided internally, we are working on getting away from having a global Selected Network in the wallet.

josheleonard
josheleonard suggested changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also request this list directly from core to remove the need to store it in redux.

@Douglashdaniel Douglashdaniel force-pushed the feat-edit-visible-asset-network-selector branch from 287a7d9 to 1fbc33c Compare October 20, 2022 18:05
@Douglashdaniel Douglashdaniel force-pushed the feat-edit-visible-asset-network-selector branch 3 times, most recently from ff1747e to 4abc5d9 Compare October 20, 2022 20:04
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the feat-edit-visible-asset-network-selector branch from 4abc5d9 to 7a2f9f2 Compare October 20, 2022 21:03
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit e4eacf8 into master Oct 21, 2022
@Douglashdaniel Douglashdaniel deleted the feat-edit-visible-asset-network-selector branch October 21, 2022 02:23
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 21, 2022
@srirambv srirambv mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onyb onyb onyb left review comments

@josheleonard josheleonard josheleonard approved these changes

@muliswilliam muliswilliam Awaiting requested review from muliswilliam

Assignees

@Douglashdaniel Douglashdaniel

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.47.x - Release
4 participants
@Douglashdaniel @brave-builds @onyb @josheleonard