Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Fix crash with non-utf-8 RSS feeds. #15714

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#26321

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fallaciousreasoning fallaciousreasoning merged commit 73a9de1 into master Nov 1, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-subscribe-fixes branch November 1, 2022 00:07
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 1, 2022
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.47.36 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. install 1.47.36
  2. launch Brave
  3. set brave://flags/#brave-news-v2 to Enabled
  4. set brave://flags/#brave-news-subscribe-button to Enabled
  5. click Relaunch
  6. load https://www.pravda.com.ua/eng/news/

Confirmed no crashes when loading https://www.pravda.com.ua/eng/news/ with the above flags enabled

Screen Shot 2022-11-01 at 2 02 01 PM

kjozwiak added a commit that referenced this pull request Nov 3, 2022
[Uplift] [Brave News]: Fix crash with non-utf-8 RSS feeds. (#15714)
@@ -211,7 +230,7 @@ void DirectFeedController::FindFeeds(

// Response is valid, but still might not be a feed
ParseFeedDataOffMainThread(
feed_url, body_content,
feed_url, charset, std::move(body_content),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This std::move of body_content is problematic since it means body_content is empty when accessed later in the callback if the content was HTML and not RSS. I'm pretty sure it's causing brave/brave-browser#26550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave News crashes when loading https://www.pravda.com.ua/eng/news/ with v2 enabled
4 participants