Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sns pref for android #16381

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Sns pref for android #16381

merged 2 commits into from
Dec 16, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Dec 15, 2022 •
edited
Loading

Resolves brave/brave-browser#27392
Resolves brave/brave-browser#27378

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Added brave://flags/#brave-wallet-sns for Desktop and Android
  • Added SNS pref(hidden if feature flag is not set) for Android(similar to ENS and UD)
    image

@supermassive supermassive requested a review from a team as a code owner December 15, 2022 04:56
supermassive
supermassive commented Dec 15, 2022
View reviewed changes
android/brave_java_sources.gni
@@ -183,8 +183,8 @@ brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/PopupWindowTooltip.java",
"../../brave/android/java/org/chromium/chrome/browser/custom_layout/popup_window_tooltip/PopupWindowTooltipUtils.java",
"../../brave/android/java/org/chromium/chrome/browser/decentralized_dns/settings/ENSSettingsFragment.java",
"../../brave/android/java/org/chromium/chrome/browser/decentralized_dns/settings/RadioButtonGroupENSResolveMethodPreference.java",
"../../brave/android/java/org/chromium/chrome/browser/decentralized_dns/settings/RadioButtonGroupUnstoppableDomainsResolveMethodPreference.java",
"../../brave/android/java/org/chromium/chrome/browser/decentralized_dns/settings/RadioButtonGroupDDnsResolveMethodPreference.java",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RadioButtonGroupDDnsResolveMethodPreference options are same for ENS, SNS and UD

@supermassive supermassive requested a review from yrliou December 15, 2022 05:24
AlexeyBarabash
AlexeyBarabash approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 9e693fe
reason: unsigned
Please follow the handbook to configure commit signing
cc: @supermassive

SergeyZhukovsky
SergeyZhukovsky approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

goodov
goodov approved these changes Dec 16, 2022
View reviewed changes
android/brave_java_resources.gni Outdated
# Copyright 2020 The Brave Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
# Copyright (c) 2022 The Brave Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls keep the existing copyright year.

@supermassive supermassive enabled auto-merge (rebase) December 16, 2022 08:16
@supermassive supermassive merged commit 47baad9 into master Dec 16, 2022
@supermassive supermassive deleted the sns_pref_android branch December 16, 2022 09:00
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 16, 2022
@srirambv srirambv mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@AlexeyBarabash AlexeyBarabash AlexeyBarabash approved these changes

Assignees

@supermassive supermassive

Labels
None yet
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging this pull request may close these issues.

Add SNS pref for Android Expose SNS feature flag via brave:://flags
4 participants
@supermassive @goodov @SergeyZhukovsky @AlexeyBarabash