Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet GPS): wallet services issue from activity #17162

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

Pavneet-Sing
Copy link

Resolves brave/brave-browser#28452

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Not able to reproduce though app should not crash after
    • Exiting app after login or setup
    • Exiting app after network switching
    • Exiting app after changing time frame on graph

@Pavneet-Sing Pavneet-Sing added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 13, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Feb 13, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@srirambv
Copy link
Contributor

Verification passed on Lenovo Tab with Android 12 running 1.50.37 x64 Nightly build

  • Verified no crash after setting up the wallet
  • Verified no crash when changing the time frame on graph
  • Verified no crash when changing network
  • Verified no crash on lock/unlocking the wallet
  • Verified no crash on both clean install and upgrade install
  • Verified no crash when restoring wallet from seed phrase

kjozwiak pushed a commit that referenced this pull request Feb 15, 2023
kjozwiak pushed a commit that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in PortfolioFragment
3 participants