Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a LinearLayoutManager wrapper for a RecyclerView crash workaround on Android #18002

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Apr 11, 2023

Resolves brave/brave-browser#29634

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

It's provided in the original issue.

@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Apr 11, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Apr 11, 2023
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 21, 2023

Verification Completed on Samsung GS 21 using the following version(s):

Brave	1.52.60 Chromium: 112.0.5615.138 (Official Build) canary (64-bit) 
Revision	2258f2fcaeb07bc95c992b7ca47f0b43ead9865c-refs/branch-heads/5615@{#1282}
OS	Android 13; Build/TP1A.220624.014

STR: brave/brave-browser#29860 (comment)

  1. Install 1.52.60 (Nightly Channel)
  2. Complete onboarding, don't set brave as default.
  3. Open another tab (keep first tab)
  4. Enable news via NTP card on second tab
  5. Confirm feed is showing in current tab
  6. Enable rewards (US)
  7. Allow notifications when dialog presented
  8. Skip through rewards tutorial
  9. Switch to original tab using tab tray
  • Ensured crash is not reproducible when switching tabs after enabling rewards profile (Nightly Channel).
  • Ensured user is able to interact with news, scroll, start rewards and change tabs.
crash_fix1.mp4

kjozwiak pushed a commit that referenced this pull request Apr 25, 2023
…d on Android (uplift to 1.51.x) (#18149)

Uplift of #18002 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Apr 25, 2023
…d on Android (uplift to 1.50.x) (#18150)

Uplift of #18002 (squashed) to release

Co-authored-by: brave-builds <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in RecyclerView
4 participants