-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BR panel progress bar not shown for failed balance #18012
BR panel progress bar not shown for failed balance #18012
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
77e4dce
to
e7ad9ad
Compare
e7ad9ad
to
993664f
Compare
993664f
to
21039f8
Compare
Verified PASSED on As per the omments brave/brave-browser#29054 (comment), the @Miyayes @sujitacharya2005 @deeppandya Could you review this and share your thoughts on whether we can uplift this PR? Thanks! |
I have discussed with @Miyayes. @Miyayes agreed this for current iteration. brave/brave-browser#29054 (comment) |
Resolves brave/brave-browser#29054
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: