Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR panel progress bar not shown for failed balance #18012

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Apr 12, 2023

Resolves brave/brave-browser#29054

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@sujitacharya2005 sujitacharya2005 added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Apr 12, 2023
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sujitacharya2005 sujitacharya2005 force-pushed the 29054_BR_panel_progress_bar_not_shown branch from 993664f to 21039f8 Compare April 14, 2023 09:46
@sujitacharya2005 sujitacharya2005 merged commit 4d6f08e into master Apr 14, 2023
@sujitacharya2005 sujitacharya2005 deleted the 29054_BR_panel_progress_bar_not_shown branch April 14, 2023 11:43
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 14, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 18, 2023

Verified PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.52.53

As per the omments brave/brave-browser#29054 (comment), the Loading... text is removed from the loading spinner in BR panel, but the spinner icon is overlapping on the Your Balance text which looks odd.

@Miyayes @sujitacharya2005 @deeppandya Could you review this and share your thoughts on whether we can uplift this PR? Thanks!
cc: @kjozwiak @LaurenWags

BR panel
Screenshot_20230418-101712_Brave - Nightly

@sujitacharya2005
Copy link
Contributor Author

sujitacharya2005 commented Apr 18, 2023

Hi @GeetaSarvadnya

I have discussed with @Miyayes.
before fix and after fix there is no change for spinner.
Only update here in this fix is show the spinner until it's success.
For fail case spinner will not hide.

@Miyayes agreed this for current iteration. brave/brave-browser#29054 (comment)

kjozwiak pushed a commit that referenced this pull request Apr 18, 2023
kjozwiak pushed a commit that referenced this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants