Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless enable notifications dialog on Android 8 (uplift to 1.51.x) #18052

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Endless enable notifications dialog on Android 8 (uplift to 1.51.x) #18052

merged 1 commit into from
Apr 17, 2023

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 13, 2023 •
edited by kjozwiak
Loading

Uplift of #17972
Resolves brave/brave-browser#29563

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner April 13, 2023 21:01
@brave-builds brave-builds self-assigned this Apr 13, 2023
@brave-builds brave-builds added this to the 1.51.x - Beta milestone Apr 13, 2023
kjozwiak
kjozwiak approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.51.x approved 👍 QA has verified the PR on Nightly as per #17972 (comment).

@kjozwiak kjozwiak merged commit e550aed into 1.51.x Apr 17, 2023
@kjozwiak kjozwiak deleted the pr17972_Android_8_notification_permission_dialog_1.51.x branch April 17, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak