Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Allow Removing Auto Discovered Tokens #18459

Merged
merged 1 commit into from
May 15, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where removing Auto Discovered tokens would be re-added again.

Resolves brave/brave-browser#28749

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels May 11, 2023
@Douglashdaniel Douglashdaniel force-pushed the fix-removing-auto-discovered-tokens branch from f62b4c7 to 75976f7 Compare May 11, 2023 20:57
@Douglashdaniel Douglashdaniel changed the title fix(wallet): Removing Auto Discovered Tokens fix(wallet): Allow Removing Auto Discovered Tokens May 11, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel marked this pull request as ready for review May 12, 2023 13:46
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner May 12, 2023 13:46
@Douglashdaniel Douglashdaniel force-pushed the fix-removing-auto-discovered-tokens branch from f51365d to bf7caa8 Compare May 15, 2023 06:08
@Douglashdaniel Douglashdaniel requested a review from onyb May 15, 2023 06:10
@Douglashdaniel Douglashdaniel force-pushed the fix-removing-auto-discovered-tokens branch from bf7caa8 to 5de5113 Compare May 15, 2023 14:00
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@onyb onyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel force-pushed the fix-removing-auto-discovered-tokens branch from 5de5113 to 9b5f686 Compare May 15, 2023 15:08
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the fix-removing-auto-discovered-tokens branch from 9b5f686 to 551650a Compare May 15, 2023 15:24
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit f01c20d into master May 15, 2023
@Douglashdaniel Douglashdaniel deleted the fix-removing-auto-discovered-tokens branch May 15, 2023 17:11
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-discovery of assets resets the visible assets pref.
4 participants