Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pending contribution code #18680

Merged
merged 1 commit into from
May 31, 2023
Merged

Remove pending contribution code #18680

merged 1 commit into from
May 31, 2023

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#29218

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing requested review from a team as code owners May 30, 2023 20:03
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 30, 2023
mkarolin
mkarolin approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

emerick
emerick approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing force-pushed the ksmith-remove-pending branch from 3b0806f to 08fa273 Compare May 30, 2023 21:01
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing force-pushed the ksmith-remove-pending branch from 08fa273 to c952c81 Compare May 30, 2023 21:23
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing force-pushed the ksmith-remove-pending branch from c952c81 to 48cec05 Compare May 31, 2023 14:06
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing merged commit d2c0364 into master May 31, 2023
@zenparsing zenparsing deleted the ksmith-remove-pending branch May 31, 2023 18:38
@github-actions github-actions bot added this to the 1.54.x - Nightly milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@emerick emerick emerick approved these changes

@szilardszaloki szilardszaloki szilardszaloki approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@zenparsing zenparsing

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging this pull request may close these issues.

Remove all Pending Contributions code
6 participants
@zenparsing @brave-builds @kylehickinson @emerick @szilardszaloki @mkarolin