Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wallet) Fix NFT Pinning eligibility text #18692

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix(wallet) Fix NFT Pinning eligibility text #18692

merged 2 commits into from
Jul 31, 2023

Conversation

muliswilliam
Copy link
Contributor

Resolves brave/brave-browser#30550

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Screenshot 2023-05-31 at 14 29 43 Screenshot 2023-05-31 at 14 22 46

@muliswilliam muliswilliam requested review from a team as code owners May 31, 2023 11:35
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels May 31, 2023
josheleonard
josheleonard approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@muliswilliam muliswilliam force-pushed the fix-nft-pinning-eligibility-text branch from 17e8f22 to 3c091f8 Compare May 31, 2023 13:38
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

SergeyZhukovsky
SergeyZhukovsky approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ wallet core part

mkarolin
mkarolin approved these changes May 31, 2023
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@muliswilliam muliswilliam force-pushed the fix-nft-pinning-eligibility-text branch from 3c091f8 to 26dae18 Compare June 15, 2023 06:59
@muliswilliam muliswilliam force-pushed the fix-nft-pinning-eligibility-text branch from 26dae18 to 988abe5 Compare July 4, 2023 11:18
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam force-pushed the fix-nft-pinning-eligibility-text branch from 988abe5 to 521bfa2 Compare July 25, 2023 16:56
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@muliswilliam muliswilliam merged commit b48f47b into master Jul 31, 2023
@muliswilliam muliswilliam deleted the fix-nft-pinning-eligibility-text branch July 31, 2023 13:06
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 31, 2023
@srirambv srirambv mentioned this pull request Aug 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyZhukovsky SergeyZhukovsky SergeyZhukovsky approved these changes

@josheleonard josheleonard josheleonard approved these changes

@mkarolin mkarolin mkarolin approved these changes

Assignees

@muliswilliam muliswilliam

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.

Update NFT Pinning eligibility text
5 participants
@muliswilliam @brave-builds @SergeyZhukovsky @josheleonard @mkarolin