Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore missing icons #18975

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Restore missing icons #18975

merged 2 commits into from
Jun 21, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#31160
Resolves brave/brave-browser#31162

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See issues

@fallaciousreasoning fallaciousreasoning self-assigned this Jun 20, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jun 20, 2023
@fallaciousreasoning fallaciousreasoning enabled auto-merge (squash) June 21, 2023 00:58
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 74bf452 into master Jun 21, 2023
@fallaciousreasoning fallaciousreasoning deleted the icons-missing branch June 21, 2023 02:35
@github-actions github-actions bot added this to the 1.55.x - Nightly milestone Jun 21, 2023
fallaciousreasoning added a commit that referenced this pull request Jul 11, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jul 12, 2023

Verified with

Brave | 1.58.14 Chromium: 115.0.5790.75 (Official Build) nightly (x86_64)
-- | --
Revision | 815908cbe94089a9ec75b79616db88e66e1ed1d4
OS | macOS Version 13.4.1 (a) (Build 22F770820b)

brave/brave-browser#31162 - PASSED

Reproduced the issue using 1.57.8 Chromium: 115.0.5790.75.
Verified icon was displayed as expected using 1.58.14 Chromium: 115.0.5790.75.

1.57.8 Chromium: 115.0.5790.75 1.58.14 Chromium: 115.0.5790.75
1 2

Verified with

Brave	1.58.14 Chromium: 115.0.5790.75 (Official Build) nightly (64-bit) 
Revision	815908cbe94089a9ec75b79616db88e66e1ed1d4
OS	Windows 10 Version 22H2 (Build 19045.3086)

brave/brave-browser#31160 - PASSED

Reproduced the issue using 1.57.8 Chromium: 115.0.5790.75.
Verified icon was displayed as expected using 1.58.14 Chromium: 115.0.5790.75.

1.57.8 Chromium: 115.0.5790.75 1.58.14 Chromium: 115.0.5790.75
1 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
4 participants