Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable download protection allowlist for all desktop builds #18997

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jun 22, 2023

Fixes brave/brave-browser#26183

Security review: https://github.com/brave/security/issues/1324

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Ensure that Safe Browsing is enabled in your browser before testing this (it's enabled by default).

  1. Open the browser and wait 5 minutes for Safe Browsing to finish initializing.
  2. Open brave://safe-browsing/#tab-download-protection and leave it open in a tab.
  3. Open https://fmarier.org/sb-uws.html in another tab.
  4. Click on the link to start downloading a zip file.
  5. Verify that the file is downloaded properly and not blocked.
  6. Go back to the brave://safe-browsing/#tab-download-protection tab.
  7. Verify that the last two sections (Download requests (ClientDownloadRequest) sent and Download responses (ClientDownloadResponse) received) are empty:
    Screenshot from 2023-06-22 12-30-49

@fmarier fmarier self-assigned this Jun 22, 2023
@fmarier fmarier requested a review from a team as a code owner June 22, 2023 19:32
@fmarier fmarier self-assigned this Jun 22, 2023
@fmarier fmarier force-pushed the download-protection-allowlist-26183 branch from 852aeae to c3115c9 Compare June 22, 2023 20:01
@fmarier fmarier force-pushed the download-protection-allowlist-26183 branch from c3115c9 to b8142fe Compare June 22, 2023 23:37
@fmarier fmarier force-pushed the download-protection-allowlist-26183 branch from b8142fe to 7d5877c Compare June 22, 2023 23:51
@fmarier fmarier requested a review from iefremov June 23, 2023 03:30
@fmarier fmarier added this to the 1.55.x - Nightly milestone Jun 26, 2023
@fmarier fmarier merged commit f580973 into master Jun 26, 2023
@fmarier fmarier deleted the download-protection-allowlist-26183 branch June 26, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download protection service (SafeBrowsing) is blocking a file from google.com
3 participants