Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet): Unlock Wallet Page V2 #19280

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

  • Updates the Unlock Wallet page to the new Wallet V2 designs

Resolves brave/brave-browser#31603

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to brave://wallet
  2. You will see the new Unlock Wallet page design
  3. Test and make sure everything works correctly
  4. Enable Enable Panel v2 flage in brave://flags
  5. Open the panel, you should see the new Unlock Wallet Panel V2 design
  6. Test and make sure everything works correctly
Screen.Recording.30.mov

Screenshot 66

Screenshot 65

@Douglashdaniel Douglashdaniel requested review from a team as code owners July 13, 2023 21:51
@Douglashdaniel Douglashdaniel self-assigned this Jul 13, 2023
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Jul 13, 2023
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l10n string++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel enabled auto-merge July 14, 2023 01:44
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@Douglashdaniel Douglashdaniel merged commit e077429 into master Jul 14, 2023
@Douglashdaniel Douglashdaniel deleted the unlock-wallet-page-v2 branch July 14, 2023 13:12
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Wallet Unlock screen to V2 design
5 participants