-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Filter out Zero Balance Groups #19308
Conversation
...nts/brave_wallet_ui/components/desktop/views/portfolio/components/token-lists/token-list.tsx
Outdated
Show resolved
Hide resolved
...nts/brave_wallet_ui/components/desktop/views/portfolio/components/token-lists/token-list.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l10n strings ++
A Storybook has been deployed to preview UI for the latest push |
b8face1
to
2260565
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
@@ -7,10 +7,14 @@ import NoAccountsIconLight from './no-accounts-icon-light.svg' | |||
import NoAccountsIconDark from './no-accounts-icon-dark.svg' | |||
import NoTransactionsIconLight from './no-transactions-icon-light.svg' | |||
import NoTransactionsIconDark from './no-transactions-icon-dark.svg' | |||
import NoTokensIconLight from './no-tokens-icon-light.svg' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I going to advise u 2 return every penny @
Description
Network
andAccount
groups that have azero
balance on thePortfolio
pageGroup by
option tonone
empty
state when there are not tokens to display on thePortfolio
pageResolves brave/brave-browser#31147
Resolves brave/brave-browser#31680
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Portfolio
page and open theFilter and display settings
Networks
orAccounts
and clickSave changes
Empty Token List
stateCall to action
buttons and make sure they work (Deposit, Buy crypto, Add custom asset)Screen.Recording.32.mov