Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Filter out Zero Balance Groups #19308

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

  • Filters out Network and Account groups that have a zero balance on the Portfolio page
  • Changes the default Group by option to none
  • Add's an empty state when there are not tokens to display on the Portfolio page

Resolves brave/brave-browser#31147
Resolves brave/brave-browser#31680

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Portfolio page and open the Filter and display settings
  2. Uncheck all Networks or Accounts and click Save changes
  3. You should see the Empty Token List state
  4. Test all of the Call to action buttons and make sure they work (Deposit, Buy crypto, Add custom asset)
Screen.Recording.32.mov

Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l10n strings ++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel force-pushed the filter-out-zero-balance-groups branch from b8face1 to 2260565 Compare July 17, 2023 19:43
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

@@ -7,10 +7,14 @@ import NoAccountsIconLight from './no-accounts-icon-light.svg'
import NoAccountsIconDark from './no-accounts-icon-dark.svg'
import NoTransactionsIconLight from './no-transactions-icon-light.svg'
import NoTransactionsIconDark from './no-transactions-icon-dark.svg'
import NoTokensIconLight from './no-tokens-icon-light.svg'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I going to advise u 2 return every penny @

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
6 participants