Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make #brave-adblock-cookie-list-default enabled by default #19754

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Aug 17, 2023

Resolves brave/brave-browser#29986

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See attached issue

@antonok-edm antonok-edm requested review from pes10k and mkarolin August 17, 2023 22:36
@antonok-edm antonok-edm self-assigned this Aug 17, 2023
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is very good and i like it very much

@antonok-edm antonok-edm enabled auto-merge August 17, 2023 22:44
@antonok-edm antonok-edm force-pushed the cookie-list-default-enabled branch 2 times, most recently from 6c1c6f5 to 7d8f62a Compare August 22, 2023 19:26
@kjozwiak
Copy link
Member

kjozwiak commented Sep 6, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.59.76 Chromium: 116.0.5845.163 (Official Build) nightly (64-bit)
-- | --
Revision | 882a1d617108cea1c78439e27c5f19c46b276508
OS | Windows 11 Version 22H2 (Build 22621.2215)

Using the STR/Cases outlined via brave/brave-browser#29986 (comment), went through the following and ensured that brave://flags#brave-adblock-cookie-list-default enabled is being enabled by default on first launch.

  • ensured that the Default for brave://flags#brave-adblock-cookie-list-default enabled is set as Enabled
  • ensured that EasyList Cookies is enabled via brave://settings/shields/filters on first launch
  • ensured that there's no cookie consent message appearing under https://www.digikey.com on first launch
  • ensured that brave://flags#brave-adblock-cookie-list-default enabled is still enabled after restarting the browser
    • basically ensuring that once Griffin studies are being applied, #brave-adblock-cookie-list-default enabled is still enabled
    • ensured that EasyList Cookies is still enabled via brave://settings/shields/filters once Griffin studies are applied
  • ensured that the cookie consent banner is appearing under https://www.digikey.com after disabling EasyList Cookies
    • disabled via brave://settings/shields/filters and ensured disabling/enabling worked as expected

Before Restarting (no Griffin studies applied)

Example Example Example Example
beforeRestart1 beforeRestart2 beforeRestart3 beforeRestart4

After Restarting (Griffin studies being applied)

Example Example
afterRestart1 afterRestart2

After disabling EasyList Cookies via brave://settings/shields/filters

disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie List should be enabled at first launch
3 participants