Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clean copy url service interface for iOS (uplift to 1.58.x) #20017

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Add clean copy url service interface for iOS (uplift to 1.58.x) #20017

merged 1 commit into from
Sep 6, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Sep 6, 2023 •
edited
Loading

Uplift of #19079
Resolves brave/brave-browser#32484

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@cuba cuba added the CI/run-network-audit Run network-audit label Sep 6, 2023
@cuba cuba added this to the 1.58.x - Beta milestone Sep 6, 2023
@cuba cuba self-assigned this Sep 6, 2023
@cuba cuba requested a review from a team as a code owner September 6, 2023 16:04
@github-actions github-actions bot removed the CI/run-network-audit Run network-audit label Sep 6, 2023
@kylehickinson kylehickinson changed the title Add clean copy url service interface for iOS (uplift to 1.57.x) Add clean copy url service interface for iOS (uplift to 1.58.x) Sep 6, 2023
@mkarolin mkarolin mentioned this pull request Sep 6, 2023
Merged
25 tasks
@cuba cuba force-pushed the js/19079-clean-copy-uplift-1.58 branch from 2cb56c4 to d447acc Compare September 6, 2023 20:53
@kjozwiak kjozwiak mentioned this pull request Sep 6, 2023
Closed
kjozwiak
kjozwiak approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍

@kjozwiak kjozwiak merged commit 0290ad5 into 1.58.x Sep 6, 2023
@kjozwiak kjozwiak deleted the js/19079-clean-copy-uplift-1.58 branch September 6, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@cuba cuba

Labels
None yet
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@cuba @kjozwiak