Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foreground service type for wireguard service #20099

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Add foreground service type for wireguard service #20099

merged 3 commits into from
Sep 12, 2023

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#32906

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Sep 11, 2023
@deeppandya deeppandya added this to the 1.60.x - Nightly milestone Sep 11, 2023
@deeppandya deeppandya self-assigned this Sep 11, 2023
deeppandya
deeppandya commented Sep 11, 2023
View reviewed changes
android/java/AndroidManifest.xml
@@ -200,6 +200,7 @@

<service
android:name="org.chromium.chrome.browser.vpn.wireguard.WireguardService"
android:foregroundServiceType="dataSync"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samartnik using dataSync based on https://developer.android.com/about/versions/14/changes/fgs-types-required#data-sync. Chromium also uses the same for DownloadForegroundService

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

samartnik
samartnik approved these changes Sep 11, 2023
View reviewed changes
android/java/AndroidManifest.xml
@@ -200,6 +200,7 @@

<service
android:name="org.chromium.chrome.browser.vpn.wireguard.WireguardService"
android:foregroundServiceType="dataSync"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This was referenced Sep 11, 2023
Merged
Merged
@deeppandya deeppandya disabled auto-merge September 11, 2023 15:39
@bsclifton bsclifton mentioned this pull request Sep 11, 2023
Closed
@deeppandya deeppandya force-pushed the add_foreground_service_type branch from 43f9ceb to 1cbe183 Compare September 12, 2023 04:16
tapanmodh
tapanmodh suggested changes Sep 12, 2023
View reviewed changes
@deeppandya deeppandya disabled auto-merge September 12, 2023 04:39
tapanmodh
tapanmodh approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya
Add foreground service type for wireguard service
9e97676
@deeppandya
Update manifest
d3df9a9 
Add livedata for purchases

Update livedata implementation
@deeppandya deeppandya force-pushed the add_foreground_service_type branch from 1cbe183 to d3df9a9 Compare September 12, 2023 15:17
@deeppandya deeppandya merged commit 3dd1866 into master Sep 12, 2023
@deeppandya deeppandya deleted the add_foreground_service_type branch September 12, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tapanmodh tapanmodh tapanmodh approved these changes

@samartnik samartnik samartnik approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.60.x - Release
Development

Successfully merging this pull request may close these issues.

[Android] Add foregroundservice type for android 14 changes
3 participants
@deeppandya @tapanmodh @samartnik