-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added system default theme mode on linux #21065
Conversation
7ef58a2
to
64844cc
Compare
64844cc
to
fbb1044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
lgtm
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#14685 (comment), reproduced the original issue using
Using the STR/Cases outlined via #21065 (comment), ensured that the fix/changes were working as per the following:
|
Uplift of #21065 (squashed) to beta
Resolves brave/brave-browser#14685
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Same as Linux
theme settings option.Dark
orLight
and check browser theme is changed properlySame as Linux
Dark
orLight
Same as Linux