chore: consolidate tx confirmation panels

[josheleonard]

Resolves brave/brave-browser#34661

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

Transaction confirmation panel should continue to display all pertinent information for all transaction types without major regression

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[Douglashdaniel]

LGTM!

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[github-actions]

[puLL-Merge] - brave/brave-core@21188

Description

The PR refactors the components/brave_wallet_ui/common/hooks/use-pending-transaction.ts and relevant component files by including transaction detection for ZCash and Bitcoin, as well as removing previous files and code related to distinct transaction confirmations which seem to be now handled in a more unified manner.

Changes

Changes

• use-pending-transaction.ts: The hook now includes isZCashTransaction and isBitcoinTransaction functions to detect respective transaction types; furthermore, it replaces an undefined value with a boolean false in the returned condition, ensuring a consistent return type.

• Deleted Panels: Specific confirmation panels for Bitcoin, Solana, and ZCash (bitcoin-transaction-info.tsx, confirm-bitcoin-transaction-panel.tsx, confirm-solana-transaction-panel.stories.tsx, confirm-solana-transaction-panel.tsx, confirm-zcash-transaction-panel.tsx) have been removed, suggesting a consolidation of transaction panels into a more generic component that handles multiple cryptocurrencies.

• components/brave_wallet_ui/components/extension/confirm-transaction-panel/confirm-transaction-panel.stories.tsx & .tsx: Adjustments made to accommodate the deletion of specific transaction components, and modifications to better handle the display of transaction confirmation data for multiple transaction types.

• components/brave_wallet_ui/components/extension/confirm-transaction-panel/transaction-info.tsx: The transaction info display component has been updated to include conditions for handling ZCash and Bitcoin transaction information, alongside the already existing Ethereum and Filecoin transactions.

• components/brave_wallet_ui/components/extension/transaction-box/index.tsx: This file has been updated to handle the presentation of transaction details for Bitcoin, ZCash, and Solana in addition to Ethereum and Filecoin, indicating a more unified approach to transaction info display.

• components/brave_wallet_ui/panel/container.tsx: Refactored to remove conditionals that directed to specific transaction panels, pointing towards a single ConfirmTransactionPanel being used for all types.

Security Hotspots

• The changes introduce new types of transactions. Each new type requires validation to ensure transaction details are handled securely.
• The use of external inputs to determine transaction type (isBitcoinTransaction, isZCashTransaction) should be checked for any potential injections or handling of unvalidated data.
• Consolidated transaction UI components must ensure there is no opportunity for sensitive information leaks between different transaction types being handled in shared components.

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[brave-builds]

A Storybook has been deployed to preview UI for the latest push

[srirambv]

Verification passed on

Brave	1.64.4 Chromium: 121.0.6167.75 (Official Build) nightly (64-bit)
Revision	85d10cf
OS	Linux

• Verified steps from PR
• Verified transaction confirmation panel continue to show all transaction information for all transaction types without any regression