Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Remove Yandex' trackers from URLs #21254

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Dec 5, 2023

Resolves brave/brave-browser#33216

This reverts commit 478e120, reinstating fca0aa8.

We probably don't need to wait for brave/brave-browser#10188 since compat problems are unlikely given ysclid in already removed by uBO and Firefox Nightly.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open https://brave.com/?ymclid=1234&ysclid=abcde.
  2. Confirm that the URL bar shows just https://brave.com/ (the two parameters were removed).

@fmarier fmarier requested a review from bridiver December 5, 2023 21:03
@fmarier fmarier self-assigned this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Yandex trackers from the query string
2 participants