Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 121.0.6167.85 to Chromium 121.0.6167.139 #21826

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Upgrade from Chromium 121.0.6167.85 to Chromium 121.0.6167.139 #21826

merged 3 commits into from
Jan 31, 2024

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jan 30, 2024

Resolves brave/brave-browser#35704

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added this to the 1.64.x - Nightly milestone Jan 30, 2024
@emerick emerick requested a review from a team January 30, 2024 21:22
@emerick emerick self-assigned this Jan 30, 2024
@emerick emerick requested review from a team as code owners January 30, 2024 21:22
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) labels Jan 30, 2024
@emerick emerick force-pushed the 121.0.6167.139_master branch from 6a3226a to bfad230 Compare January 31, 2024 00:13
kjozwiak
kjozwiak approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kjozwiak kjozwiak merged commit 6ddcd27 into master Jan 31, 2024
19 checks passed
@kjozwiak kjozwiak deleted the 121.0.6167.139_master branch January 31, 2024 03:50
@kjozwiak kjozwiak mentioned this pull request Jan 31, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@emerick emerick

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.64.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 121.0.6167.85 to Chromium 121.0.6167.139
3 participants
@emerick @kjozwiak @brave-builds