Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds voice recognition for Leo prompts on Android #22748

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

SergeyZhukovsky
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky commented Mar 25, 2024

Resolves brave/brave-browser#37053

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open Leo.
  2. Tap a microphone icon in the input box.
  3. Say something.
  4. Observe Leo responses to your prompt.
Screen_recording_20240325_112052.mp4

Screenshot_20240325-114529
Screenshot_20240325-114229

@SergeyZhukovsky SergeyZhukovsky self-assigned this Mar 25, 2024
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 25, 2024
@SergeyZhukovsky SergeyZhukovsky added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 and removed CI/storybook-url Deploy storybook and provide a unique URL for each build CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-ios Do not run CI builds for iOS labels Mar 25, 2024
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 25, 2024
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@SergeyZhukovsky SergeyZhukovsky merged commit dabc7d1 into master Mar 25, 2024
19 checks passed
@SergeyZhukovsky SergeyZhukovsky deleted the android_leo_voice branch March 25, 2024 18:38
@github-actions github-actions bot added this to the 1.66.x - Nightly milestone Mar 25, 2024
brave-builds added a commit that referenced this pull request Mar 26, 2024
brave-builds added a commit that referenced this pull request Mar 26, 2024
@hffvld
Copy link
Collaborator

hffvld commented Mar 26, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP21.240216.010 release-keys
Brave build: 1.66.35 
Chromium: 123.0.6312.58 (Official Build) canary (64-bit) 

STEPS:

  1. Followed the steps from Adds voice recognition for Leo prompts on Android #22748 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Mic is shown in the query text field
  • Verified that tapping a Mic opens Android native permission message and then opens UI for the voice query
  • Verified that the Android permission message opened only for the first attempt
  • Verified that voice recognition is working, the query is sent automatically and the answer is received as expected
  • Verified the same in English and Russian languages

1 2 3 4 5
1 2 3 4 5
2024-03-26_14-10-59.mp4
2024-03-26_14-12-10.mp4

kjozwiak pushed a commit that referenced this pull request Mar 26, 2024
kjozwiak pushed a commit that referenced this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an ability to dictate Leo prompt
7 participants