Remove lion animation onboarding #27133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-macos-x64
mherrmann
reviewed
Jan 7, 2025
| @@ -292,40 +291,10 @@ private int getAnalyticsConsentPageStep() { | |||
| } | |||
|
|
|||
| private void showIntroPage() { | |||
| int margin = mIsTablet ? 100 : 0; | |||
There was a problem hiding this comment.
With these changes, can we remove mTvWelcome, tv_welcome and welcome_to_brave?
mherrmann
reviewed
Jan 7, 2025
| @@ -292,40 +291,10 @@ private int getAnalyticsConsentPageStep() { | |||
| } | |||
|
|
|||
| private void showIntroPage() { | |||
| int margin = mIsTablet ? 100 : 0; | |||
There was a problem hiding this comment.
It's no longer really an intro page so I would inline showIntroPage. But that's more of a style preference than a strict requirement.
|
@mherrmann I would need to update a few more things in the same PR after the discussion. I will ping again for the review. |
Refactor the changes and add comments
deeppandya
force-pushed
the
remove_lion_animation_onboarding
branch
from
e1d4b2b to
ace8e8b
Compare
|
Closing the Pr as creating a new one with more changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#43116
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
screen-20250106-122717.mp4