Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable hyperlink auditing by appending kNoPings option #342

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Disable hyperlink auditing by appending kNoPings option #342

merged 1 commit into from
Aug 20, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 20, 2018 •
edited
Loading

This option disables sending pings for anchor elements

Close brave/brave-browser#764

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

yarn test brave_browser_tests --filter=BraveMainDelegateBrowserTest.DisableHyperlinkAuditing

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong
Disable hyperlink auditing by appending kNoPings option
d6ed3e5 
This option disables sending pings for anchor elements
@simonhong simonhong self-assigned this Aug 20, 2018
@simonhong simonhong requested a review from bbondy August 20, 2018 02:49
@bbondy bbondy merged commit ff3ef0d into master Aug 20, 2018
@bbondy bbondy deleted the disable_hyperlink_auditing branch August 23, 2018 13:39
mkarolin added a commit that referenced this pull request May 17, 2022
@mkarolin
Revert disabling anchor ping attribute.
a78e14a 
Fixes brave/brave-browser#22904

This reverts
brave/brave-browser#764
#342
@mkarolin mkarolin mentioned this pull request May 17, 2022
Merged
25 tasks
mkarolin added a commit that referenced this pull request May 18, 2022
@mkarolin
Revert disabling anchor ping attribute.
9710a69 
Fixes brave/brave-browser#22904

This reverts
brave/brave-browser#764
#342
mkarolin added a commit that referenced this pull request May 21, 2022
@mkarolin
Revert disabling anchor ping attribute.
a598d95 
Fixes brave/brave-browser#22904

This reverts
brave/brave-browser#764
#342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bbondy