Manual uplift of PR 5039 "Implement User wallets (Uphold) on Android" to 1.9.x

[gdregalo]

Uplift of PR #5039
"Implement User wallets (Uphold) on Android" to 1.9.x
Fixes brave/brave-browser#8511

• You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
• You have tested your change on Nightly.
• The PR milestones match the branch they are landing to.

After you merge:

• The associated issue milestone is set to the smallest version that the changes is landed on.

[kjozwiak]

This is waiting on QA to basically run through user wallets on Nightly before approving and merging into 1.9.x. @LaurenWags mind adding the cases/update that you ran through in this PR?

@gdregalo mind fixing the conflict? Looks like the following files have a conflict:

* android/java/res/values/brave_colors.xml
* browser/ui/android/strings/android_brave_strings.grd

[LaurenWags]

Verification in progress
Uphold wallet checks performed with staging env on LG Nexus 5 w/ Android 5.1 using

Brave | 1.10.22 Chromium: 81.0.4044.129 (Official Build) canary (32-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | Android 5.1; Nexus 5 Build/LMY47D

• Confirmed can connect KYC'd account.
• Confirmed after connecting KYC'd account uphold sandbox balance is reflected in panel and on chrome://rewards page.
• Confirmed able to one time tip. Confirmed tip is deducted from balance and displayed on the panel summary and on the tips section of chrome://rewards page.
• Confirmed opening panel and tapping on 'Wallet Verified', all options on this popup behaved as expected:
  • Add/Withdraw Funds navigated me to appropriate pages on sandbox.uphold.com.
  • Go to my Uphold account navigated me to sandbox uphold dashboard.
  • Disconnect from Brave Rewards showed Disconnected wallet status on panel.
• Confirmed able to disconnect/reconnect within browser from panel, unable to confirm needing to reconnect in 60 days.
• Confirmed able to remove Brave Browser connection via sandbox.uphold.com (under Authorized Applications). Confirmed able to reconnect via panel on Android.
• Confirmed when in Disconnected state, Uphold sandbox balance is not displayed on panel or chrome://rewards page.
• Confirmed able to add BAT in uphold sandbox and see wallet balance update to reflect the new BAT.
• Confirmed "connected" messaging on panel and tip banner when visiting a publisher who is Brave verified but not KYC'd and only Uphold sandbox BAT exists in the wallet (no Brave controlled funds like ad grants, UGP).
• Confirmed if wallet only has Uphold sandbox BAT, unable to tip a connected publisher. Your balance does not go down, tip does not appear in tips list. Note - we should check that this goes to the pending contributions list. However, this currently does not display on Android. Logged as [Android] Missing pending list view brave-browser#9331.
• Confirmed the following scenario (needs to be re-verified when [Android] User wallets not permitted up to a threshold of BAT earner brave-browser#9636 is implemented)
  • claim ad grant and UGP grant
  • sign up for Uphold acct
  • Wait for KYC to go thru.
  • Confirm once KYC goes thru,
    a) you get notification about this - this does not occur. Logged [Android] "Your wallet is verified" notification does not display on Android brave-browser#9787
    b) ad grant only is moved to Uphold sandbox account (confirmed in Uphold account and confirmed using below logs:

05-14 16:34:20.007 29454-29492/? V/chromium: [VERBOSE1:ledger_impl.cc(965)] 
    [ RESPONSE - OnTransferAnonToExternalWallet ]
    > time: 1589488460
    > result: Success
    > http code: 200
    > response: {}
    > headers accept-ranges: bytes
    > headers cache-control: private
    > headers content-length: 2
    > headers content-type: application/json; charset=utf-8
    > headers date: Thu, 14 May 2020 20:34:21 GMT
    > headers server: Cowboy
    > headers status: 200
    > headers via: 1.1 varnish
    > headers x-cache: MISS
    > headers x-cache-hits: 0
    > headers x-served-by: cache-pwk4953-PWK
    [ END RESPONSE ]

05-14 16:34:21.083 29454-29492/? V/chromium: [VERBOSE1:ledger_impl.cc(965)] 
    [ RESPONSE - DeleteTokens ]
    > time: 1589488461
    > result: Success
    > http code: 200
    > response: 
    > headers accept-ranges: bytes
    > headers content-length: 0
    > headers content-type: application/json
    > headers date: Thu, 14 May 2020 20:34:22 GMT
    > headers request-id: bquqmji2dk8qbbuanff0
    > headers status: 200
    > headers via: 1.1 varnish
    > headers x-cache: MISS
    > headers x-cache-hits: 0
    > headers x-ratelimit-limit: 1
    > headers x-ratelimit-remaining: 0
    > headers x-ratelimit-reset: 1
    > headers x-request-id: 677vtYYQRc77GoWZ
    > headers x-served-by: cache-ewr18145-EWR
    [ END RESPONSE ]

TBD - recurring tips (only funded via Uphold sandbox)
TBD - AC (only funded via Uphold sandbox)
TBD - recurring tip + AC (only funded via Uphold sandbox)
TBD - claim UGP and confirm can tip connected (not KYC'd) publishers until UGP runs out.
TBD - login with non KYC'd uphold sandbox act and confirm unable to see wallet balance in rewards
TBD - perform claim scenario and watch for lag/perf issues or balance drop. Basic outline of scenario: have ad grant on Android, connect a KYC'd wallet (or non-KYC'd wallet but go thru KYC process), use device while ad grant is being moved to Uphold wallet. Watch for any lag or perf issues. Check panel/rewards page to look for balance drop.

Logged issues:

• [Android] bottom banner on wallet panel on chrome://rewards should match desktop brave-browser#9575 - wallet panel doesn't match desktop when Uphold wallet is connected
• [Android] no notification when wallet is disconnected brave-browser#9576 - no notification text when uphold wallet is disconnected
• [Android] "Your wallet is verified" notification does not display on Android brave-browser#9787 - no notification text when uphold wallet is fully Verified/KYC'd

[srirambv]

We should probably close this PR as we are still waiting on brave/brave-browser#9636

[bsclifton]

This is pushed back to 1.10 at a minimum; going to close this out