[NOT FOR MERGE] Most recently used tab with Ctrl-Tab cycling #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
simonhong
changed the title
simonhong
force-pushed
the
guifel-1/mru-clycling-ctrl-tab
branch
from
1ff0e68 to
620e74a
Compare
simonhong
force-pushed
the
guifel-1/mru-clycling-ctrl-tab
branch
4 times, most recently
from
f4ec4e2 to
a03d739
Compare
simonhong
force-pushed
the
guifel-1/mru-clycling-ctrl-tab
branch
2 times, most recently
from
cd18bdb to
28da6b5
Compare
simonhong
added
CI/skip-android
Communication from tab_strip_model to controllers is acheived by have the controllers implementing TabStripModelObserver. I chosed to add a virtual empty function on TabStripModelObserver with chromium_src. I did not do a simple sub-classing because it would have required patching/change all the controllers that rely on TabStripObserver (many). I also considered the rename and extend in chromium_src method but that doesn't work because of TabStripObserver static methods.
During the mru cycling, tab can be closed with shortcut. In that case, current cycling is ended and new cycling will be started.
Can't resolve now for chrome/browser circular dependency.
* Delete redundant IsKeyEvent() checking * Don't use MRU outside of TabStripModel.
simonhong
force-pushed
the
guifel-1/mru-clycling-ctrl-tab
branch
from
28da6b5 to
9a91afa
Compare
|
weird - @simonhong I wonder why this one shows as merged on GitHub? Maybe because it has the same HEAD as the #4671? |
|
I assume that the reason is both have same commits? |
|
Although this is not the directly merged PR, milestone is set because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for running CI instead of #4671
Resolves brave/brave-browser#913
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.