Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable wearable notifications. Ads won't look right on such a small … #5797

Merged

Conversation

yachtcaptain23
Copy link
Contributor

@yachtcaptain23 yachtcaptain23 commented Jun 9, 2020

…screen, as

our guidelines focus on mobile and desktop, not wearables.

When we choose to implement or test this in the future,
https://developer.android.com/training/wearables/apps/creating#emulator is a great guide
for emulating Wear OS on the computer with a physical phone.

Closes brave/brave-browser#9397

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Android
    • iOS
    • Linux
    • macOS
    • Windows
  • Verified that these changes pass automated tests (unit, browser, security tests) on
    • iOS
    • Linux
    • macOS
    • Windows
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
  • Public documentation has been updated as necessary.

Test Plan:

In BraveActivity.java, fire a BraveOnboardingNotification

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

…screen, as

our guidelines focus on mobile and desktop, not wearables.

When we choose to implement or test this in the future,
https://developer.android.com/training/wearables/apps/creating#emulator is a great guide
for emulating Wear OS on the computer with a physical phone.

Closes brave#9397
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM__

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yachtcaptain23 yachtcaptain23 merged commit 1b3dbcf into brave:master Jun 10, 2020
@yachtcaptain23 yachtcaptain23 deleted the bugfix/wearable_notification branch June 10, 2020 16:46
@bbondy
Copy link
Member

bbondy commented Jun 10, 2020

yay! @yachtcaptain23 please add a milestone on the issue and the PR (1.12.x)

@yachtcaptain23 yachtcaptain23 added this to the 1.12.x - Nightly milestone Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Brave ads can't be opened on watch notification issue
4 participants