Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Remote Debugging preference #5965

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#9715

Submitter Checklist:

Test Plan:

See brave/brave-browser#9715

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

- Removes the preference
- Removes from Settings page
- This is on by default and proxied now, thanks to brave/brave-browser#7645

Fixes brave/brave-browser#9715
@bsclifton bsclifton self-assigned this Jun 29, 2020
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member Author

test-install failed on macOS (seems to be a common problem; not related to this PR). Otherwise, CI looks great! 👍

@bsclifton bsclifton requested review from diracdeltas and rebron June 29, 2020 21:50
@jumde jumde added the CI/run-network-audit Run network-audit label Jun 29, 2020
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Looks great.

@bsclifton bsclifton added this to the 1.12.x - Nightly milestone Jun 29, 2020
@bsclifton bsclifton merged commit 2c9019f into master Jun 29, 2020
@bsclifton bsclifton deleted the bsc-remove-remote-debugging branch June 29, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Remove preference for toggling RemoteDebugging
6 participants