Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds UI to clear browsing data flow #6020

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Adds UI to clear browsing data flow #6020

merged 1 commit into from
Jul 15, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 7, 2020 •
edited
Loading

Resolves brave/brave-browser#926

Submitter Checklist:

Test Plan:

  • enable rewards
  • go to settings -> clear data dialog
  • make sure that you see reset rewards link and clicking on it opens manage wallet dialog

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Jul 7, 2020
@NejcZdovc NejcZdovc force-pushed the clear-data-rewards branch from b9cfa0d to aa88320 Compare July 13, 2020 07:04
@NejcZdovc NejcZdovc requested review from petemill, a team, emerick and zenparsing and removed request for a team July 13, 2020 08:37
@NejcZdovc NejcZdovc force-pushed the clear-data-rewards branch from aa88320 to 649fc6e Compare July 13, 2020 10:06
@NejcZdovc NejcZdovc marked this pull request as ready for review July 13, 2020 10:09
@NejcZdovc NejcZdovc requested a review from bridiver as a code owner July 13, 2020 10:09
@NejcZdovc NejcZdovc force-pushed the clear-data-rewards branch from 649fc6e to 9eac7c0 Compare July 13, 2020 10:09
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jul 13, 2020
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 13, 2020
emerick
emerick approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

petemill
petemill previously requested changes Jul 13, 2020
View reviewed changes
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adapting to the new style. Just a couple minor issues, if you don't mind.

@NejcZdovc NejcZdovc force-pushed the clear-data-rewards branch from 9eac7c0 to e9cc038 Compare July 13, 2020 19:53
@NejcZdovc NejcZdovc requested a review from petemill July 13, 2020 19:53
bridiver
bridiver approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@bridiver bridiver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src changes are fine

@NejcZdovc
Copy link
Contributor Author

CI failed on test-install

@fmarier
Copy link
Member

fmarier commented Jul 14, 2020

@NejcZdovc Are you able to share a screenshot of what it looks like now?

@NejcZdovc
Copy link
Contributor Author

@fmarier this is what we show on every tab now. Clicking on it will open Manage wallet on rewards page
image

@NejcZdovc NejcZdovc merged commit 3bfef37 into master Jul 15, 2020
@NejcZdovc NejcZdovc deleted the clear-data-rewards branch July 15, 2020 05:36
@LaurenWags LaurenWags mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

@emerick emerick emerick approved these changes

@zenparsing zenparsing zenparsing approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@NejcZdovc NejcZdovc

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging this pull request may close these issues.

Add clear rewards data and clear payment data
6 participants
@NejcZdovc @fmarier @bridiver @petemill @emerick @zenparsing