Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes panel actions for uphold limit (uplift to 1.12.x) #6219

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Fixes panel actions for uphold limit (uplift to 1.12.x) #6219

merged 2 commits into from
Jul 28, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 27, 2020 •
edited by LaurenWags
Loading

Uplift of #6217
Uplift of #6220
Resolves brave/brave-browser#10855
Resolves brave/brave-browser#10944

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from NejcZdovc as a code owner July 27, 2020 18:35
@brave-builds brave-builds requested a review from a team July 27, 2020 18:35
@brave-builds brave-builds self-assigned this Jul 27, 2020
@brave-builds brave-builds added this to the 1.12.x - Beta milestone Jul 27, 2020
@NejcZdovc NejcZdovc removed their request for review July 27, 2020 18:35
LaurenWags
LaurenWags approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6217 (comment) and #6220 (comment)

@LaurenWags LaurenWags merged commit fe77728 into 1.12.x Jul 28, 2020
@LaurenWags LaurenWags deleted the pr6217_uphold-limit_1.12.x branch July 28, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

Assignees

@brave-builds brave-builds

Labels
feature/rewards
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @LaurenWags @NejcZdovc @brave-browser-releases