Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Brave sync chain instead of Brave Account #6317

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Use Brave sync chain instead of Brave Account #6317

merged 1 commit into from
Aug 5, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 3, 2020 •
edited by rebron
Loading

Resolves brave/brave-browser#10469

Submitter Checklist:

Test Plan:

  1. Download latest nightly 1.14.19 and higher
  2. Go to a website that requires username and password.
  3. Select password icon in the url bar and notice that text should read: Passwords are saved in your Brave sync chain so you can use them on any device

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.14.x - Nightly milestone Aug 3, 2020
@simonhong simonhong requested review from bbondy and bsclifton August 3, 2020 07:46
@simonhong simonhong self-assigned this Aug 3, 2020
bsclifton
bsclifton approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ LGTM

@bsclifton bsclifton requested a review from mkarolin August 3, 2020 09:08
@bbondy bbondy changed the title Use Brave sync chagin instead of Brave Account Use Brave sync chain instead of Brave Account Aug 3, 2020
bbondy
bbondy requested changes Aug 3, 2020
View reviewed changes
script/lib/transifex.py Outdated
@@ -499,6 +499,8 @@ def braveify(string_value):
.replace('Brave Play', 'Google Play')
.replace('Brave Safe', 'Google Safe')
.replace('Sends URLs of some pages you visit to Brave', 'Sends URLs of some pages you visit to Google'))
.replace('Brave will save this password in your Brave Account', 'Brave will save this password in your Brave sync chain')
.replace('Passwords are saved in your Brave Account', 'Passwords are saved in your Brave sync chain')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should run npm run chromium_rebase_l10n to see the grd or grdp changes.
Maybe try Brave Account -> Brave sync chain instead to see if it produces sane results?

Copy link
Member Author

@simonhong simonhong Aug 3, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from Brave Account to Brave sync chain will be fine.
Should we run chromium_rebase_l10n for getting this change on local?
push_l10n only does this string replacement.
Previously, we should do chromium_rebase_l10n. but maybe this process was changed?

Ah, Ok. I found script/lib/grd_string_replacements.py.
I was confused I thought we do additional string fixup only with this.

@simonhong simonhong force-pushed the fix_brave_account_strings branch from 386c731 to 4b6e181 Compare August 3, 2020 22:27
@simonhong simonhong requested a review from bbondy August 3, 2020 22:30
@simonhong simonhong marked this pull request as draft August 4, 2020 00:55
@simonhong simonhong force-pushed the fix_brave_account_strings branch from 4b6e181 to bb9524b Compare August 4, 2020 01:23
@simonhong simonhong marked this pull request as ready for review August 4, 2020 01:28
@simonhong simonhong force-pushed the fix_brave_account_strings branch from bb9524b to 2797283 Compare August 4, 2020 01:30
@simonhong simonhong merged commit d2e08cb into master Aug 5, 2020
@simonhong simonhong deleted the fix_brave_account_strings branch August 5, 2020 01:17
brave-builds pushed a commit that referenced this pull request Aug 10, 2020
@brave-browser-releases
Uplift of #6317 (squashed) to beta
f35c0cd
@brave-builds brave-builds mentioned this pull request Aug 10, 2020
Merged
4 tasks
@kjozwiak
Copy link
Member

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.39 Chromium: 85.0.4183.59 (Official Build) nightly (64-bit)
-- | --
Revision | 7cc9a5ee672625c38427a839cb1b15efd3128084-refs/branch-heads/4183@{#1216}
OS | macOS Version 10.15.6 (Build 19G73)
Example 1 Example 2 Example 3
Screen Shot 2020-08-14 at 12 31 17 PM Screen Shot 2020-08-14 at 12 32 14 PM Screen Shot 2020-08-14 at 12 33 22 PM

@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@bsclifton bsclifton bsclifton approved these changes

@mkarolin mkarolin Awaiting requested review from mkarolin

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging this pull request may close these issues.

[Desktop] Remove Brave Account branding for password storage
4 participants
@simonhong @kjozwiak @bbondy @bsclifton