Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewards page initialization check #6323

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Aug 3, 2020

Resolves brave/brave-browser#10717

Submitter Checklist:

Test Plan:

Test case in brave-browser issue.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing force-pushed the ksmith-rewards-1-10-upgrade branch from 03f14e0 to 1dfd0a4 Compare August 3, 2020 18:29
@zenparsing zenparsing requested a review from emerick August 3, 2020 19:47
@zenparsing zenparsing force-pushed the ksmith-rewards-1-10-upgrade branch from 1dfd0a4 to 767e5d4 Compare August 3, 2020 19:56
@zenparsing zenparsing requested a review from tmancey as a code owner August 3, 2020 19:56
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Aug 4, 2020
@NejcZdovc NejcZdovc merged commit bd171ae into master Aug 4, 2020
@NejcZdovc NejcZdovc deleted the ksmith-rewards-1-10-upgrade branch August 4, 2020 09:13
NejcZdovc added a commit that referenced this pull request Aug 4, 2020
Add rewards page initialization check
NejcZdovc added a commit that referenced this pull request Aug 4, 2020
Add rewards page initialization check
@LaurenWags
Copy link
Member

Verified using

Brave | 1.14.18 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Upgrades from 1.10.x --> 1.14.x

Note - Also observed panel shows Join messaging when upgrading from 1.10.x to 1.14.x. This also occurs with 1.10.x to 1.12.x and is not related to this PR. Investigation was done with @NejcZdovc and was shared here: https://bravesoftware.slack.com/archives/CB0KCRCQN/p1596633919026400?thread_ts=1596630882.025600&cid=CB0KCRCQN

Also checked the below using 1.11.x --> 1.14.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] monthly payment isn't always displayed on brave://rewards correctly - follow up to 10438
5 participants