-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rewards page initialization check #6323
Conversation
03f14e0
to
1dfd0a4
Compare
1dfd0a4
to
767e5d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add rewards page initialization check
Add rewards page initialization check
Verified using
Upgrades from 1.10.x --> 1.14.x
Note - Also observed panel shows Join messaging when upgrading from 1.10.x to 1.14.x. This also occurs with 1.10.x to 1.12.x and is not related to this PR. Investigation was done with @NejcZdovc and was shared here: https://bravesoftware.slack.com/archives/CB0KCRCQN/p1596633919026400?thread_ts=1596630882.025600&cid=CB0KCRCQN Also checked the below using 1.11.x --> 1.14.x
|
Resolves brave/brave-browser#10717
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Test case in brave-browser issue.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.