-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnab… #6480
Conversation
…led; fixes brave-browser#11363
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Verification passed on OnePlus 6T with Android 10 running 1.15.9 x64 nightly build.
|
@AlexeyBarabash mind creating a |
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled use reflection
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled
…led; fixes brave-browser#11363
Resolves brave/brave-browser#11363
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Use steps from brave/brave-browser#11363
Reviewer Checklist:
After-merge Checklist:
changes has landed on.