Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnab… #6480

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

AlexeyBarabash
Copy link
Contributor

…led; fixes brave-browser#11363

Resolves brave/brave-browser#11363

Submitter Checklist:

Test Plan:

Use steps from brave/brave-browser#11363

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@AlexeyBarabash AlexeyBarabash added feature/sync CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Aug 24, 2020
@AlexeyBarabash AlexeyBarabash self-assigned this Aug 24, 2020
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash AlexeyBarabash merged commit 009abf3 into master Aug 24, 2020
@AlexeyBarabash AlexeyBarabash deleted the android_sync_fix_11363 branch August 24, 2020 18:59
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.15.9 x64 nightly build.

  • Verified opening a private tab on clean install doesn't show the sync not available message

@kjozwiak
Copy link
Member

@AlexeyBarabash mind creating a 1.13.x uplift for this so can merge both #6417 & #6480 at the same time?

AlexeyBarabash added a commit that referenced this pull request Aug 25, 2020
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled
AlexeyBarabash added a commit that referenced this pull request Aug 25, 2020
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled

use reflection
AlexeyBarabash added a commit that referenced this pull request Aug 26, 2020
Use isFirstSetupComplete instead isSyncRequested for isChromeSyncEnabled
@AlexeyBarabash AlexeyBarabash added this to the 1.15.x - Nightly milestone Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android][Follow up #11210] Sync not working message showing up on private tabs
6 participants