Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 85.0.4183.78 to Chromium 85.0.4183.83 (1.13.x). #6490

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Aug 25, 2020

Resolves brave/brave-browser#11401
Related PR: brave/brave-browser#11419

Uplift from #6481

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade patches from Chromium 85.0.4183.78 to Chromium 85.0.4183.83
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Aug 25, 2020
@mkarolin mkarolin added this to the 1.13.x - Release milestone Aug 25, 2020
@mkarolin mkarolin requested a review from a team August 25, 2020 15:14
@mkarolin mkarolin requested a review from bridiver as a code owner August 25, 2020 15:14
@mkarolin mkarolin self-assigned this Aug 25, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Aug 25, 2020

test-unit failed on Android as per https://ci.brave.com/job/pr-brave-browser-85.0.4183.83-1.13.x-android/3/execution/node/196/log/. However, @mihaiplesa mentioned this is a known issue due to running the Android builds using the wrong labels. Will be resolved sometime today/tomorrow once @linhkikuchi comes online. Doesn't block uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.13.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit cb996e4 into 1.13.x Aug 26, 2020
@kjozwiak kjozwiak deleted the 85.0.4183.83-1.13.x branch August 26, 2020 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants