Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bottomsheet behaviour (uplift to 1.14.x) #6543

Merged

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 31, 2020

Uplift of #6537

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team August 31, 2020 04:23
@brave-builds brave-builds self-assigned this Aug 31, 2020
@brave-builds brave-builds added this to the 1.14.x - Beta milestone Aug 31, 2020
@kjozwiak
Copy link
Member

Restarting macOS via https://ci.brave.com/job/brave-core-build-pr-macos/job/PR-6543/2/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr6537_privacy_report_bottom_sheet_behaviour_1.14.x-macos/1/execution/node/174/log/.

01:22:51  [40215/43064] CXX obj/chrome/browser/ui/ui/chrome_web_ui_controller_factory.o
01:22:51  FAILED: obj/chrome/browser/ui/ui/chrome_web_ui_controller_factory.o 

test-browser failed on Win x64 due to GreaselionServiceTest.ScriptInjectionWithPrecondition failing as per https://ci.brave.com/job/pr-brave-browser-pr6537_privacy_report_bottom_sheet_behaviour_1.14.x-windows/1/execution/node/216/log/. However, this is a known intermittent failure and doesn't block uplift.

01:41:35  [  FAILED  ] GreaselionServiceTest.ScriptInjectionWithPrecondition, where TypeParam =  and GetParam() =  (2938 ms)
01:41:35  
01:41:35  [607/607] GreaselionServiceTest.ScriptInjectionWithPrecondition (3120 ms)
01:41:35  1 test failed:
01:41:35      GreaselionServiceTest.ScriptInjectionWithPrecondition (../../brave/browser/greaselion/greaselion_browsertest.cc:265)

test-install failed on Win x64 as per https://ci.brave.com/job/pr-brave-browser-pr6537_privacy_report_bottom_sheet_behaviour_1.14.x-windows/1/execution/node/240/log/. We usually like to get test-install passing but it's not the most reliable when it comes to stability. Other platforms passed without any issues and we've seen this failure happen on other PRs as well. Hence, not blocking uplift.

@kjozwiak
Copy link
Member

@deeppandya macOS keeps failing init as per https://ci.brave.com/job/pr-brave-browser-pr6537_privacy_report_bottom_sheet_behaviour_1.14.x-macos/2/execution/node/104/log/. Assuming this one will need to get rebased.

@deeppandya deeppandya force-pushed the pr6537_privacy_report_bottom_sheet_behaviour_1.14.x branch from 3f2703f to 4163c36 Compare August 31, 2020 21:16
@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2020

test-browser failed on Win x64 due to GreaselionServiceTest.ScriptInjectionWithPrecondition failing as per https://ci.brave.com/job/pr-brave-browser-pr6537_privacy_report_bottom_sheet_behaviour_1.14.x-windows/2/execution/node/216/log/. However, this is a known intermittent failure and doesn't block uplift.

19:13:50  [  FAILED  ] GreaselionServiceTest.ScriptInjectionWithPrecondition, where TypeParam =  and GetParam() =  (2866 ms)
19:13:50  
19:13:50  [605/606] GreaselionServiceTest.ScriptInjectionWithPrecondition (3040 ms)
19:13:51  [606/606] RewardsContributionBrowserTest.MultipleTipsProduceMultipleFeesWithVerifiedWallet (1311 ms)
19:13:51  1 test failed:
19:13:51      GreaselionServiceTest.ScriptInjectionWithPrecondition (../../brave/browser/greaselion/greaselion_browsertest.cc:265)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #6494 (comment).

@kjozwiak kjozwiak merged commit dc87b8a into 1.14.x Sep 1, 2020
@kjozwiak kjozwiak deleted the pr6537_privacy_report_bottom_sheet_behaviour_1.14.x branch September 1, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants