-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly cancel blocked requests #6632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spinda You'll probably need to update some of the browsertests - there's at least one that uses an $explicitcancel
rule in components/brave_shields/browser/ad_block_service_browsertest.cc
also any new tests are welcome, especially browsertests :) The change looks good |
cae8de1
to
82df613
Compare
I ended up removing the |
cc: @iefremov for re-review 😄 |
@spinda could you give this a rebase? Sorry that it's taken a while to work through this PR |
Oops, accidentally deleted the branch! Rebasing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spinda it looks like this needs to be rebased again?
82df613
to
0f9b911
Compare
@pes10k Rebased again! |
Merged! Thanks again @spinda ! |
Revert "Merge pull request #6632 from spinda/explicitly-cancel-blocke…
Resolves brave/brave-browser#10063
Fixes, for example, video playback on https://abcnews.go.com/Politics/video/tennessee-celebrates-100-years-womens-vote-72455124, where returning an empty stub response for https://abcnewsplayer-a.akamaihd.net/player/2.106.5/akamai/amp/nielsen/Nielsen.min.js causes another script to misbehave.
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.