Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-functional verify wallet button on rewards page (uplift to 1.18.x) #7213

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Fix non-functional verify wallet button on rewards page (uplift to 1.18.x) #7213

merged 1 commit into from
Nov 26, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 20, 2020 •
edited by kjozwiak
Loading

Uplift of #7210
Resolves brave/brave-browser#12812

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner November 20, 2020 17:52
@brave-builds brave-builds requested review from marshall, zenparsing and a team and removed request for a team November 20, 2020 17:52
@brave-builds brave-builds self-assigned this Nov 20, 2020
@brave-builds brave-builds added this to the 1.18.x - Beta milestone Nov 20, 2020
@LaurenWags
Copy link
Member

Restarted macOS and Windows

@kjozwiak
Copy link
Member

Restarting Win x64 via https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-windows/3/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-windows/2/execution/node/199/log/. Looks like CI had issues communicating with the Win x64 node.

10:26:03  Cannot contact i-010136f3af7471e8b-windows-swarm-37244c39: hudson.remoting.RequestAbortedException: java.nio.channels.ClosedChannelException
10:31:03  Could not connect to i-010136f3af7471e8b-windows-swarm-37244c39 to send interrupt signal to process

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-macos/3/ due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-macos/2/execution/node/203/log/.

10:54:01  FAILED: obj/chrome/browser/media/router/discovery/discovery/dial_media_sink_service.o

@kjozwiak
Copy link
Member

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-macos/4/ as build failed as per https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-macos/3/execution/node/203/log/.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 25, 2020 •
edited
Loading

Restarting macOS via https://ci.brave.com/job/pr-brave-browser-pr7210_ksmith-fix-verify-modal_1.18.x-macos/5/ as the node it's using was taken offline.

kjozwiak
kjozwiak approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #7210 (comment).

@kjozwiak kjozwiak merged commit d94a1dd into 1.18.x Nov 26, 2020
@kjozwiak kjozwiak deleted the pr7210_ksmith-fix-verify-modal_1.18.x branch November 26, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@marshall marshall Awaiting requested review from marshall

@zenparsing zenparsing Awaiting requested review from zenparsing

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @LaurenWags @kjozwiak @brave-browser-releases