Brave Rewards Favicon #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bridiver
reviewed
Oct 29, 2018
|
ping, is this PR still in progress or should we close it out? |
rossmoody
force-pushed
the
rewards-favicon
branch
from
8b600fe to
78ff8d7
Compare
- uploaded a favico for rewards pages
rossmoody
force-pushed
the
rewards-favicon
branch
from
84ffa4b to
c13c8db
Compare
|
followed up with @petemill. ditched the hash designation for "favicon.ico" on this one but otherwise should be good to go. |
NejcZdovc
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1466
The remaining favicons for Brave owned pages should probably be owned by this issue: brave/brave-browser#1278