Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buttons not working in IPFS interstitial page (uplift to 1.19.x) #7587

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 13, 2021

Uplift of #7585
Resolves brave/brave-browser#13544

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team January 13, 2021 19:17
@brave-builds brave-builds self-assigned this Jan 13, 2021
@brave-builds brave-builds added this to the 1.19.x - Beta milestone Jan 13, 2021
@yrliou
Copy link
Member

yrliou commented Jan 13, 2021

CI builds are green expect for Windows which has unrelated rewards browser test failures.

[2021-01-13T21:51:18.031Z]     RewardsBrowserTest.BackupRestoreModalHasNotice (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:304)

[2021-01-13T21:51:18.031Z]     RewardsBrowserTest.ResetRewardsWithBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:375)

[2021-01-13T21:51:18.031Z]     RewardsBrowserTest.UpholdLimitNoBAT (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:398)

[2021-01-13T21:51:18.031Z]     RewardsContributionBrowserTest.TipConnectedPublisherVerified (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:586)

[2021-01-13T21:51:18.031Z]     RewardsContributionBrowserTest.TipUnverifiedPublisher (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:304)

[2021-01-13T21:51:18.031Z]     RewardsPromotionBrowserTest.ClaimViaSettingsPage (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:196)

[2021-01-13T21:51:18.031Z]     RewardsPromotionBrowserTest.PromotionRemovedFromEndpoint (../../brave/components/brave_rewards/browser/test/rewards_promotion_browsertest.cc:231)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.19.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7585 (comment).

@kjozwiak kjozwiak merged commit 23065ad into 1.19.x Jan 14, 2021
@kjozwiak kjozwiak deleted the pr7585_ipfs_fix_interstitial_page_1.19.x branch January 14, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants