Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BAP date calculation #7924

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Fix BAP date calculation #7924

merged 1 commit into from
Feb 11, 2021

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Feb 10, 2021

Resolves brave/brave-browser#14092

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Included in brave/brave-browser#14092

@zenparsing zenparsing requested a review from a team as a code owner February 10, 2021 21:40
@zenparsing zenparsing self-assigned this Feb 10, 2021
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zenparsing zenparsing merged commit 5769e9d into master Feb 11, 2021
@zenparsing zenparsing deleted the ksmith-fix-bap-cutoff branch February 11, 2021 00:28
brave-builds pushed a commit that referenced this pull request Feb 11, 2021
@zenparsing zenparsing added this to the 1.22.x - Nightly milestone Feb 12, 2021
zenparsing added a commit that referenced this pull request Feb 12, 2021
bsclifton added a commit that referenced this pull request Feb 18, 2021
This reverts commit 5769e9d, reversing
changes made to edac78c.
This was referenced Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAP cutoff date isn't correctly detected
2 participants