Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixed action buttons layout for custom tabs (uplift to 1.23.x) #8483

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Apr 8, 2021

Uplift of #8480
Resolves brave/brave-browser#9113

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team April 8, 2021 16:16
@brave-builds brave-builds self-assigned this Apr 8, 2021
@brave-builds brave-builds added this to the 1.23.x - Release milestone Apr 8, 2021
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 8, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers. QA we'll verify this on 1.23.x once we get an RC. We would need to wait till tomorrow AM to get a Nightly to QA the above before uplifting. In the spirit of getting a 1.23.x RC ready for tomorrow, we're skipping Nightly verification. Worst case, we revert if needed.

@kjozwiak kjozwiak merged commit 29bed99 into 1.23.x Apr 9, 2021
@kjozwiak kjozwiak deleted the pr8480_android_action_buttons_fix_1.23.x branch April 9, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants