Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 90.0.4430.61 to Chromium 90.0.4430.70 (1.24.x). #8516

Merged
merged 1 commit into from
Apr 14, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Apr 12, 2021

Fixes brave/brave-browser#15239
Related PR: brave/brave-browser#15249
Uplift from #8509

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade patches from Chromium 90.0.4430.61 to Chromium 90.0.4430.70.
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Apr 12, 2021
@mkarolin mkarolin requested a review from a team April 12, 2021 22:19
@mkarolin mkarolin requested a review from a team as a code owner April 12, 2021 22:19
@mkarolin mkarolin self-assigned this Apr 12, 2021
@kjozwiak
Copy link
Member

Restarting iOS as build failed as per https://ci.brave.com/job/pr-brave-browser-pr8484_ksmith-onboarding-promo-fix_1.24.x-ios/1/execution/node/147/log/.

21:02:48  FAILED: obj/third_party/webrtc/modules/rtp_rtcp/rtp_rtcp_format/rtp_header_extension_map.o 

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-pr8484_ksmith-onboarding-promo-fix_1.24.x-macos/1/execution/node/164/log/.

21:02:50  FAILED: obj/third_party/blink/renderer/bindings/modules/v8/v8/v8_dedicated_worker_global_scope.o 

Restarting Linux due to RewardsPublisherBrowserTest.VisitUnverifiedPublisher failing. I haven't seen this fail often so I'll restart Linux just in case. If it passes, I'll create a new issue as an intermittent crash.

22:37:20  1 test crashed:
22:37:20      RewardsPublisherBrowserTest.VisitUnverifiedPublisher (../../brave/components/brave_rewards/browser/test/rewards_publisher_browsertest.cc:147)

@kjozwiak
Copy link
Member

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.24.x-macos/3/execution/node/164/log/.

05:49:19  FAILED: obj/media/base/base/audio_buffer_converter.o 

Restarting iOS due to build timing out as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.24.x-ios/3/execution/node/147/log/.

@kjozwiak
Copy link
Member

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.24.x-macos/4/execution/node/164/log/

09:59:22  FAILED: obj/brave/browser/decentralized_dns/decentralized_dns/decentralized_dns_service_factory.o 

@kjozwiak kjozwiak added this to the 1.24.x - Beta milestone Apr 13, 2021
@kjozwiak
Copy link
Member

Restarting macOS as build failed as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.24.x-macos/5/execution/node/164/log/.

15:48:07  FAILED: obj/third_party/blink/renderer/bindings/modules/v8/v8/properties_per_feature_installer.o 

@kjozwiak
Copy link
Member

Restating macOS as test-browser timed out again as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.24.x-macos/6/execution/node/254/log/.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.124.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 2497bcb into 1.24.x Apr 14, 2021
@kjozwiak kjozwiak deleted the 90.0.4430.70-1.24.x branch April 14, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants