Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 90.0.4430.61 to Chromium 90.0.4430.70 (1.23.x). #8517

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Apr 12, 2021

Fixes brave/brave-browser#15239
Related PR: brave/brave-browser#15250
Uplift from #8509

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade patches from Chromium 90.0.4430.61 to Chromium 90.0.4430.70.
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Apr 12, 2021
@mkarolin mkarolin requested a review from a team April 12, 2021 22:21
@mkarolin mkarolin requested a review from a team as a code owner April 12, 2021 22:21
@mkarolin mkarolin self-assigned this Apr 12, 2021
@kjozwiak
Copy link
Member

Restarting iOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-ios/2/execution/node/148/log/.

Restarting macOS due to build failing as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-macos/2/execution/node/165/log/.

22:30:03  FAILED: obj/third_party/blink/public/mojom/mojom_platform_blink/presentation.mojom-blink.o 

@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2021

Restarting macOS as init failed as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-macos/3/execution/node/118/log/.

06:02:09  Error: Command 'vpython3 script/download_rust_deps.py' returned non-zero exit status 1 in /Users/jenkins/jenkins/workspace/pr-brave-browser-90.0.4430.70-1.23.x-macos/src/brave
06:02:09  Hook 'vpython3 script/download_rust_deps.py' took 132.50 secs

Restarting iOS as build failed as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-ios/3/execution/node/147/log/.

06:00:50  FAILED: obj/third_party/libvpx/libvpx_asm/highbd_sad4d_sse2.o 

@kjozwiak kjozwiak added this to the 1.23.x - Release milestone Apr 13, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Apr 13, 2021

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-macos/4/execution/node/254/log/ & https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-macos/4/execution/node/257/log/. However, these are known failures and unrelated to this particular PR.

12:19:57  5 tests crashed:
12:19:57      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
12:19:57      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
12:19:57      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
12:19:57      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
12:19:57      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-linux/3/execution/node/254/log/ & https://ci.brave.com/job/pr-brave-browser-90.0.4430.70-1.23.x-linux/3/execution/node/257/log/. However, these are known failures and unrelated to this particular PR.

03:27:42  6 tests crashed:
03:27:42      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
03:27:42      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
03:27:42      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
03:27:42      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
03:27:42      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)
03:27:42      RewardsBrowserTest.ShowACPercentInThePanel (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:281)

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.23.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 402c03e into 1.23.x Apr 13, 2021
@kjozwiak kjozwiak deleted the 90.0.4430.70-1.23.x branch April 13, 2021 17:52
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
- Fix crash on active window during fresh install.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants