Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar item reordering part 1 - support item moving in sidebar model #8559

Merged
merged 2 commits into from
Apr 21, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 19, 2021

This PR implements item moving in sidebar model.
To get review easier, model and UI part will be separately pushed.

Resolves brave/brave-browser#15364

As a background,

SidebarModel/Controller manages each browser window's sidebar state.
SidebarService manages profile-wide sidebar data state.
SidebarModel observes sidebar item change event from SidebarService and manage each window's sidebar model data
because each window could have its own status such as active sidebar item.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter=Sidebar*

@simonhong simonhong self-assigned this Apr 19, 2021
@simonhong simonhong changed the title Sidebar item reordering Sidebar item reordering - part 1 Apr 19, 2021
@simonhong simonhong changed the title Sidebar item reordering - part 1 Sidebar item reordering part 1 - support item moving in sidebar model Apr 19, 2021
@simonhong simonhong marked this pull request as ready for review April 19, 2021 06:00
@simonhong simonhong requested review from mkarolin and petemill April 19, 2021 06:00
@simonhong simonhong force-pushed the sidebar_item_reordering branch from 287d46a to ebb3866 Compare April 19, 2021 06:00
@simonhong simonhong requested a review from emerick April 21, 2021 11:59
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Handling sidebar item moving in SidebarService and SidebarModel.
@simonhong simonhong force-pushed the sidebar_item_reordering branch from ebb3866 to 852c2f7 Compare April 21, 2021 14:22
@simonhong
Copy link
Member Author

Merged because previous CI run success except known failure - BraveNavigatorUserAgentFarblingMobileBrowserTest.FarbleNavigatorUserAgentMobile.

@simonhong simonhong merged commit 227ab35 into master Apr 21, 2021
@simonhong simonhong deleted the sidebar_item_reordering branch April 21, 2021 14:23
@simonhong simonhong added this to the 1.25.x - Nightly milestone Apr 21, 2021
kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
…8559)

Fix issue with stats script sending empty image sources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sidebar item reordering part 1 - support item moving in sidebar model
2 participants