Brave News: require opt-in #8830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linux CI failed only because of unrelated test: |
simonhong
reviewed
May 18, 2021
petemill
force-pushed
the
news-optin
branch
3 times, most recently
from
c1d93e3 to
d5c21d5
Compare
simonhong
reviewed
May 18, 2021
|
|
||
| type Props = { | ||
| show: boolean | ||
| onCustomizeBraveToday: () => any | ||
| } | ||
|
|
||
| const CustomizeButton = styled('button')<Props>` | ||
| const Hideable = styled('div')<Props>` |
There was a problem hiding this comment.
Suggestion: How about fixing brave/brave-browser#15221 together because you touches Customize button herre. After it's hidden, still we can click. Of course, I'm fine as a separate task.
There was a problem hiding this comment.
Good idea. I hadn't noticed that PR.
When button is not visible it won't have any even listeners and won't preven tother buttons to be clicked. # Conflicts: # components/brave_new_tab_ui/components/default/braveToday/options/customize.tsx
|
Fixed a bug that CI didn't catch which meant that the Customize button text did not get a color applied. |
bsclifton
approved these changes
May 18, 2021
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires user opt-in before fetching any data. Previously, data would wait to be fetched until the user scrolled down. Now it also waits for the user to have opted-in too. Fix Brave News should require explicit opt-in brave-browser#15926
Renames in the UI Brave Today to Brave News. Fix Rename Brave Today to Brave News brave-browser#15925
Fix Brave News customize button in some cases causes the Settings icon to go to Customize Dashboard instead of brave://settings brave-browser#15221 (thanks @Dzheky!)
Extension changes
UI changes
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: