Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check local_device_info to avoid crash on reset (uplift to 1.25.x) #8933

Merged
merged 1 commit into from
May 27, 2021
Merged

Check local_device_info to avoid crash on reset (uplift to 1.25.x) #8933

merged 1 commit into from
May 27, 2021

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented May 26, 2021 •
edited by kjozwiak
Loading

Uplift of #8929
Resolves brave/brave-browser#16066

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner May 26, 2021 13:10
@AlexeyBarabash AlexeyBarabash requested a review from a team May 26, 2021 13:10
@AlexeyBarabash AlexeyBarabash self-assigned this May 26, 2021
@AlexeyBarabash AlexeyBarabash added this to the 1.25.x - Release milestone May 26, 2021
@AlexeyBarabash
Copy link
Contributor Author

CI post-init step is UNSTABLE, failed audit-deps step:
https://ci.brave.com/job/pr-brave-browser-pr8929_sync_crash_on_reset_1.25.x-post-init/1/execution/node/145/log/ .

Not related to the PR

kjozwiak
kjozwiak approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.25.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit b271437 into 1.25.x May 27, 2021
@kjozwiak kjozwiak deleted the pr8929_sync_crash_on_reset_1.25.x branch May 27, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
None yet
Projects
None yet
Milestone
1.25.x - Release #2
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak